- Issue created by @pfrenssen
- last update
over 1 year ago run-tests.sh fatal error - @pfrenssen opened merge request.
- last update
over 1 year ago 5 pass, 2 fail - last update
over 1 year ago 9 pass - last update
over 1 year ago 9 pass - 🇧🇬Bulgaria pfrenssen Sofia
The tests are uncovering an interesting bug:
Testing Drupal\Tests\graphql_webform\Kernel\Element\ManagedFileTest E 1 / 1 (100%)R Time: 00:00.816, Memory: 6.00 MB There was 1 error: 1) Drupal\Tests\graphql_webform\Kernel\Element\ManagedFileTest::testManagedFile LogicException: Missing type Integer.
It seems we are using the
Integer
type in a few elements such asWebformElementValidationLimit
. This should beInt
instead, ref. GraphQL: Basic types.I created a followup to address this: 🐛 LogicException: Missing type Integer Fixed . I will for now mark the test as skipped. We can unskip it when the issue is fixed.
- last update
over 1 year ago 9 pass -
pfrenssen →
committed d5199e2c on 8.x-1.x
Issue #3365025 by pfrenssen: Add test coverage
-
pfrenssen →
committed d5199e2c on 8.x-1.x
- 🇧🇬Bulgaria pfrenssen Sofia
Tests are passing. This is by far not complete coverage, but the most common form elements are now covered. This already a much better baseline than having no coverage at all. Form submissions are not covered yet though.
I will merge this and will start tackling the open pull requests on Github, making sure they all get coverage as well.
- Issue was unassigned.
- Status changed to Fixed
over 1 year ago 2:55pm 6 June 2023 Automatically closed - issue fixed for 2 weeks with no activity.