OpenAI Content breaks node type edit form

Open on Drupal.org →

Created on 2 June 2023, almost 2 years ago

Problem/Motivation

Enabling the OpenAI Content module breaks the node type edit form due to a type error.

Steps to reproduce

1. Enable OpenAI Content module
2. Go to the edit form for a content type e.g. /admin/structure/types/manage/article
3. See the page fail with the following error:

Uncaught PHP Exception TypeError: "_get_all_text_with_summary_fields(): Argument #1 ($entity) must be of type Drupal\\Core\\Entity\\ContentEntityInterface, Drupal\\node\\Entity\\NodeType given, called in /app/web/modules/contrib/openai/modules/openai_content/openai_content.module on line 26" at /app/web/modules/contrib/openai/modules/openai_content/openai_content.module line 180, referer: https://drupal-ai.lndo.site/admin/structure/types/manage/page/fields

Proposed resolution

As I see it the problem occurs because we try to edit a form unintentionally.

Remaining tasks

User interface changes

None.

API changes

None.

Data model changes

None.

🐛 Bug report

Status

Fixed

Version

1.0

Component

Code

Created by

🇩🇰Denmark kasperg

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @kasperg
@kasperg opened merge request.
Status changed to Needs review almost 2 years ago11:54am 2 June 2023
Comment almost 2 years ago →
🇩🇰Denmark kasperg
I have tried to fix this by reworking our detection of content forms based on interfaces.
First commit to issue fork.
Comment almost 2 years ago →
🇺🇸United States kevinquillen
Good catch. Taking a look around, it does not error anymore and works on both adding and editing of entities. Media, for example:
Comment almost 2 years ago →
System Message

kevinquillen → committed d8b364d5 on 1.0.x authored by kasperg →
Issue #3364420 by kasperg: OpenAI Content breaks node type edit form
Status changed to Fixed almost 2 years ago1:17pm 2 June 2023
Comment almost 2 years ago →
🇺🇸United States kevinquillen
Comment almost 2 years ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024