Contrib.social

GeoConstraint allows invalid POINT values

Open on Drupal.org →
Created on 1 June 2023, over 1 year ago

Problem/Motivation

This module assumes lon comes before lat in POINT. E.g. Sydney's coordinates are roughly 31 degrees south, 151 degrees east. Most people think in terms of lat coming before lon, so would mistakenly enter POINT (-31 151) when it should be POINT(151 -31). The first should fail validation but it doesn't.

I don't think anyone's ever noticed this before because the lat lons entered via the UI don't seem to use the constraint for validation but their own custom solution. Ideally they would use the same but that's out of scope for this issue.

Steps to reproduce

Create test showing that it fails with the above coordinates.

Proposed resolution

Fix constraint to make it more robust.

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Data model changes

N/A

🐛 Bug report
Status

Needs review

Version

1.0

Component

Code

Created by

achap 🇦🇺

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024