Select List Time Validation is broken since 1.9

At OfficeHoursBaseSlot, where the validation happens, the information about am/pm is lost.
Because of that the elseif condition is false-valid.

$start = OfficeHoursDateHelper::format($input['starthours'], 'H:i', FALSE); // "09:00"
$end = OfficeHoursDateHelper::format($input['endhours'], 'H:i', TRUE); // "04:00"

elseif ($validate_hours && $end < $start) {
  // Both Start and End must be entered. That is validated above already.
  $error_text = 'Closing hours are earlier than Opening hours.';
  $erroneous_element = &$element;
}

lukasz.tyc → made their first commit to this issue’s fork.

QUick fix for validate hours

I have a problem reproducing this error: it seems I cannot create a HTML5 time input element with [Hours:Minutes am/pm]. Even if fields settings says so, the am/pm part is not shown, and always 24hrs is used.
Using a Windows 11 PC, with Edge, Chrome, Firefox .
What is your environment?

Patch #5 did not work for me; it evaluates the previous value of the input rather than the current one, so it only works as long as you are not changing the hours.

The root of the problem seems to be in the new formatters introduced in 1.9; here is a patch that targets this specifically. This resolves the validation issue for me, and may resolve other (as yet unidentified) issues as well.

Thanks,
should be fixed now.
The last commit contains some housekeeping and better message handling (time format)

Some other check is not always processed correctly.

There is an error in some PHP version "string * int" is not possible.

Automatically closed - issue fixed for 2 weeks with no activity.