Compatibility with Composer 2.5.7

Looks like OverwriteExistingPackagesValidatorTest now fails. Which kinda makes sense — it relates to the changes that 2.5.6/2.5.7 made — at @phenaproxima's request by the way! 😄

Locally, I was not getting

Testing Drupal\Tests\package_manager\Kernel\OverwriteExistingPackagesValidatorTest
F                                                                   1 / 1 (100%)

Time: 00:24.096, Memory: 4.00 MB

There was 1 failure:

1) Drupal\Tests\package_manager\Kernel\OverwriteExistingPackagesValidatorTest::testNewPackagesOverwriteExisting
Failed asserting that Drupal\package_manager\Event\PostCreateEvent Object (...) is an instance of class "Drupal\package_manager\Event\PreApplyEvent".

/var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:122
/var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:55
/var/www/html/modules/contrib/automatic_updates/package_manager/tests/src/Kernel/PackageManagerKernelTestBase.php:216
/var/www/html/modules/contrib/automatic_updates/package_manager/tests/src/Kernel/OverwriteExistingPackagesValidatorTest.php:155
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

but:

Testing /Users/wim.leers/core/modules/contrib/automatic_updates/package_manager/tests/src/Kernel
E                                                                   1 / 1 (100%)

Time: 00:02.666, Memory: 10.00 MB

There was 1 error:

1) Drupal\Tests\package_manager\Kernel\OverwriteExistingPackagesValidatorTest::testNewPackagesOverwriteExisting
Undefined array key "type"

/Users/wim.leers/core/modules/contrib/automatic_updates/package_manager/src/ComposerInspector.php:326
/Users/wim.leers/core/modules/contrib/automatic_updates/package_manager/tests/src/Traits/ComposerInstallersTrait.php:25
/Users/wim.leers/core/modules/contrib/automatic_updates/package_manager/tests/src/Kernel/OverwriteExistingPackagesValidatorTest.php:33
/Users/wim.leers/core/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

(That was happening for the Chi-teck/drupal-code-generator package.)

So I had to first overcome that.

Fix just pushed.

Now I get the same test failure. 👍

The hard failures imply that if you're on the latest stable Composer version, Package Manager/Automatic Updates will not work. That makes this a hard blocker for the alpha AFAICT.

Is there a reason we don't just bump our Composer requirement to ~2.5.7, rather than build in more workarounds for older versions?

There will always be something in upcoming Composer versions that's new/different, won't there be? We gotta draw the line somewhere. 2.5.5 has been out for >2 months. 2.5.7 for a few days.

But … sure, I'm not opposed to that 😇 😄

In this case, though, we're specifically bumping it to avoid regressions and things that directly affect us. We're not just bumping it for the sake of bumping it.

So IMHO that's the appropriate course of action, rather than adding even more code to an existing, complex workaround.

WFM!

Per discussion just now, sounds like @tedbow disagreed with #10.

re #12 I think since this Drupalcon is coming up next wee and we want people to test and install Auto Updates on an Alpha release(to be cut soon) we should not rely on a version of composer that came out last week. I think it is much likely people will already have a version 2.5.5 that was released over 2 months ago.

Many people may not want to update Composer or won't be able to because of hosting. Also the fix we want in #11455 has a BC warning so it is likely that some sites might not be able to update to it because will make another Composer plugin break. Or if update at Drupalcon they could get weird behavior because it breaks another plugin(if they were to allow it with our module). Also the fix we want already caused 1 regression https://github.com/composer/composer/pull/11481

I fix needed otherwise looks good

Merged 3.0.x. Looks good to commit when tests pass. Thanks!

Merge conflicts

omkar.podey → made their first commit to this issue’s fork.

Thanks!

One thing: can we at least have a @todo to remove the metapackage workaround when 2.5.7 is the minimum required version of Composer? 🙏

Tested manually and it fixed the problem for me (in DrupalPod / on 2.5.7). I will also close https://www.drupal.org/project/automatic_updates/issues/3365125 🐛 realpath() cannot take NULL but NULL expected for metapackages Closed: duplicate

Automatically closed - issue fixed for 2 weeks with no activity.