- Issue created by @rodricels
- @rodricels opened merge request.
- Status changed to Needs review
over 1 year ago 4:09pm 29 May 2023 - 🇪🇸Spain rodricels
Created MR to be reviewed, please give all the feedback you have to improve it if necessary.
The admin form changes a bit (Gin admin theme):
Review the MR6 on 9.5.8 drupal version. Getting this error:
error: patch failed: src/EventSubscriber/EventSubscriber.php:124
error: src/EventSubscriber/EventSubscriber.php: patch does not apply- 🇯🇵Japan ultrabob Japan
Thanks @rodricels for taking the time to make this merge request. I'll take some time to renew this in detail and get back to you with some feedback soon.
- 🇯🇵Japan ultrabob Japan
Thanks again for your work on this. I think that adding the term heaviest role into the config screen makes things more confusing, so I think we should simplify that toggle. There is a big difference in performance on a lot of transactions depending on the user role, so appending the role should default to being on. Maybe we can change the toggle text to something like:
[] Exclude role information from transaction name
help text: Transaction timings are impacted heavily by the user's role, so we recommend including role information in the transaction name.In order to keep it simple, I suggest having just two options in Additional Transaction Data:
Slow Transaction Data
User ID
User RolesWhen User Role is selected, include two custom parameters, one with all roles, and one with the highest weight role.
I think this will still get the improvements you wanted into the module while keeping the config screen as simple as we can make it.
What do you think?
- Status changed to Needs work
over 1 year ago 12:05am 6 June 2023