fix 10.0.x phpstan errors

verbal RTBC from phénaproxima. Maybe he wants deniability?

Huh? What happened here? This is NOT just fixing PHPStan errors. This de facto committed 📌 Assert no errors after creating the test project in ModuleUpdateTest Needs review ?! 😳

I've been asking to fix that for 4 months, and now it's been done here? I've surfaced this many times over the past month in meetings.

How is this related to PHPStan?

@Wim Leers sorry.

See the * @phpstan-ignore-next-line in the commit.

this was causing the code check fail on drupalci. when it was fixed it showed 10.0.7 failed.

I didn't remember there was already an issue for this in 📌 Assert no errors after creating the test project in ModuleUpdateTest Needs review . I am still not clear if that issue was causes test to fail at the time it was created. I believe it cause test to fail on 10.0.x not because drupalci was testing on specific version of core not the 10.0.x dev branch.

We can revert this and then just commit the phpstan fix. But then test will still be failing on 10.0.7

We will wait till we talk though

Closing this since re #7 once we got the code checks passing on 10.0.7 at the time we had to fix other issue

Automatically closed - issue fixed for 2 weeks with no activity.