- Issue created by @mostepaniukvm
- First commit to issue fork.
- Assigned to junkuncz
- last update
10 months ago 6 pass - last update
10 months ago 6 pass - Status changed to Needs review
10 months ago 8:27am 4 March 2024 - ππΊHungary junkuncz Budapest
I'll do more testing on the Eventsubscriber but the first round of review can be started I guess.
- ππΊHungary junkuncz Budapest
Okay it looks good, I was confused because the testes entity did not have bundles.
- Issue was unassigned.
- Status changed to Needs work
10 months ago 9:18am 8 March 2024 - π¦πΉAustria fago Vienna
thx. Code is pretty good already, I added a couple of remarks. please check
- last update
10 months ago 6 pass - last update
10 months ago 6 pass - Status changed to Needs review
10 months ago 12:23pm 10 March 2024 - Status changed to Needs work
10 months ago 10:28am 12 March 2024 - π¦πΉAustria fago Vienna
thanks, but you missed a few remarks. Please be sure to go over all of them before setting it back for review. Reviewed again anyway.
- last update
10 months ago 6 pass - Status changed to Needs review
10 months ago 11:23am 12 March 2024 - ππΊHungary junkuncz Budapest
@fago thanks for the review.
Accidentally I started a review instead of clicking on "Add new comment" button so that's why you didn't see my feedbacks.
All remarks should be covered now.
https://git.drupalcode.org/project/custom_elements/-/merge_requests/33#n...
There is a question here. - Status changed to Needs work
10 months ago 12:02pm 12 March 2024 - π¦πΉAustria fago Vienna
thanks! I added some more comments, please check
- last update
10 months ago 6 pass - Open on Drupal.org βCore: 10.2.1 + Environment: PHP 8.2 & MySQL 8last update
10 months ago Waiting for branch to pass - Open on Drupal.org βCore: 10.2.1 + Environment: PHP 8.2 & MySQL 8last update
10 months ago Waiting for branch to pass - Status changed to Needs review
10 months ago 3:42pm 12 March 2024 - ππΊHungary junkuncz Budapest
Okay it's time to do another check. (tests are fine locally)
-
fago β
committed fea86b19 on 3.x authored by
junkuncz β
Issue #3362618 by junkuncz, mostepaniukvm: Auto-generate default custom...
-
fago β
committed fea86b19 on 3.x authored by
junkuncz β
- Status changed to Fixed
10 months ago 4:05pm 12 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.