- Issue created by @yash.rode
- Assigned to yash.rode
- Status changed to Needs work
over 1 year ago 6:48am 25 May 2023 - Open on Drupal.org →Core: 10.1.x + Environment: PHP 8.1 & MySQL 8last update
over 1 year ago Not currently mergeable. - @yashrode opened merge request.
- last update
over 1 year ago 792 pass - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 7:29am 25 May 2023 - Status changed to Needs work
over 1 year ago 7:37am 25 May 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Nice catch!
But why not change the type hints to
\Drupal\package_manager_bypass\LoggingBeginner
instead? 🤔 - last update
over 1 year ago 792 pass - Status changed to Needs review
over 1 year ago 9:14am 25 May 2023 - Status changed to RTBC
over 1 year ago 1:25pm 25 May 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Surfacing this nice little improvement to the maintainers 😊
- 🇺🇸United States phenaproxima Massachusetts
Checked out this branch and ran
grep -irn 'BypassedStagerServiceBase' .
.Nothing came up, so this is good to go!
- last update
over 1 year ago 794 pass - last update
over 1 year ago 794 pass -
phenaproxima →
committed f90196ef on 3.0.x authored by
yash.rode →
Issue #3362589 by yash.rode, Wim Leers: Remove BypassedStagerServiceBase...
-
phenaproxima →
committed f90196ef on 3.0.x authored by
yash.rode →
- Status changed to Fixed
over 1 year ago 12:39pm 30 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.