Request Support for Custom Media Types

Switching to minor. This is no big deal.

Let me know if I can help at all. I could try to write some tests or something.

Thank you @alexb7217 - i have time set aside to work on this next week and appreciate your help.

Hi there @alexb7217 -

I think this is a good suggestion. I will continue work on this at a later date, but my idea was the formatter would be able to get the fieldname from it's definition. I was thinking something like:

      // If the media loaded successfully, continue with the formatting.
      if (!empty($media) && !empty($formatter_type)) {

        $fieldname = $this->fieldDefinition->getName();

        if (array_key_exists($fieldname, $media->getFields())) {

          // Grab the remote video URL.
          $video_url = $media->getFields()[$fieldname]->getValue()[0]['value'];

          // Use these to generate the URL for local oembed iframe.
          $request = new RequestContext($video_url);

needs some work as that introduces deprecations to other field types (like image etc)

I will keep this open and hope to get back to it soon. thank you for the suggestion!

It would be nice to implement that.

A first try to retrieve the field name :

        /** @var \Drupal\oembed_providers\Plugin\media\Source\OEmbed $source */
        $source = $media->getSource();
        $plugin_definition = $source->getPluginDefinition();
        $media_entity_type = \Drupal::entityTypeManager()->getStorage('media_type')->load($plugin_definition['id']);
        /** @var \Drupal\field\Entity\FieldConfig $a */
        $field_definition = $source->getSourceFieldDefinition($media_entity_type);
        $fieldname = $field_definition->getName();

Seems to do the work.
I will try to make at least a patch asap.

I'm not very comfortable with git but I committed the change on the issue fork. I don't know if I must create a merge request or if a manager of this module can do it and merge to apply the changes.

Here is the patch to resolve the problem with custom video media field.

raluca elisabeta rusu → made their first commit to this issue’s fork.

raluca elisabeta rusu → closed merge request !10

I submitted a merge request which solves the issue with all tests passed and tested on drupal 10 + 11
https://git.drupalcode.org/project/media_video_micromodal/-/merge_requests/11

It seems like merge request 11 could be more consistent with the rest of the module by using "Dependency Injection."