Contrib.social

Make it possible to set default target module machine name and path before creating

Open on Drupal.org →
Created on 23 May 2023, about 1 year ago

Problem/Motivation

While working on 📌 Add test trait to create randomly named, non-conflicting default target modules Needs review I realized that the machine name and directory of the default target module is hard coded and so can't be specified ahead of time for a test. This is a problem because TargetModuleCollection::ensureDefaultTargetModuleIsSet() is an all or nothing situation, where it won't do anything if a default target module is already installed, and if one is not installed, it will create it all and install it with the hard coded name, without giving us a chance to provide a different module name or path.

Steps to reproduce

Am tired. Please see 📌 Add test trait to create randomly named, non-conflicting default target modules Needs review for details.

Proposed resolution

Add optional parameters to TargetModuleCollection::ensureDefaultTargetModuleIsSet()

Remaining tasks

See above.

User interface changes

None.

API changes

None other than optional parameters TargetModuleCollection::ensureDefaultTargetModuleIsSet()

Data model changes

None I think?

✨ Feature request
Status

Needs review

Version

1.0

Component

Code

Created by

🇨🇦Canada Ambient.Impact Toronto

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024