Coding Standards

Created on 20 May 2023, over 1 year ago
Updated 23 May 2023, over 1 year ago

Problem/Motivation

Fix coding standards issues reported by Drupal Coder.

Steps to reproduce

Run phpcs --standard=Drupal on the module.

Proposed resolution

Fix the reported coding standards issues.

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇹🇭Thailand Nick Hope

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Nick Hope
  • @nick-hope opened merge request.
  • Status changed to Fixed over 1 year ago
  • 🇹🇭Thailand Nick Hope

    After I made all the coding standards changes remotely in the Gitlab editor, I cloned the updated repository, but drupal/coder was newly complaining that all those php files now had CRLF and not LF line endings. I assumed I had introduced them by copying and pasting stuff from my Windows VSCode, which unfortunately was set to CRLF line endings. Hence all those commits to try and remedy that. But after merging MR !6, which was before those commits, the new 8.x-1.x-dev has the correct LF line endings. So I guess I just had a local issue and I don't think those commits were necessary or even did anything at all.

  • Status changed to Fixed over 1 year ago
Production build 0.71.5 2024