- Issue created by @BigDave91
- last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago 536 pass - ๐ฆ๐นAustria drunken monkey Vienna, Austria
Thanks a lot for reporting this problem!
Youโre right, seems for extremely high scores, casting thefloat
score to an integer can actually result in a negative value. To be honest, I didnโt think this problem existed in a scripting language like PHP, the problem seems much too low-level for that. However, it clearly does, but the solution is fortunately very simple: just first determine the minimum and then cast to an integer. (Floats will never have this problem, as they have an explicit โinfinityโ value for when they exceed their maximum. (Which is, also, ridiculously high.)) - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 9:10am 20 May 2023 Thank you very much @drunken monkey โ . I just tested the patch and the problem was resolved.
-
drunken monkey โ
committed 855a5ee2 on 8.x-1.x
Issue #3361041 by BigDave91, drunken monkey: Fixed integer overflow...
-
drunken monkey โ
committed 855a5ee2 on 8.x-1.x
- Status changed to Fixed
over 1 year ago 1:24pm 27 May 2023 - ๐ฆ๐นAustria drunken monkey Vienna, Austria
Good to hear, thanks a lot for testing!
Merged. Thanks again! Automatically closed - issue fixed for 2 weeks with no activity.