- Issue created by @eojthebrave
- last update
over 1 year ago 48 pass, 2 fail - @eojthebrave opened merge request.
- last update
over 1 year ago 53 pass - Status changed to Needs review
over 1 year ago 9:13pm 15 May 2023 - πΊπΈUnited States eojthebrave Minneapolis, MN
This MR fixes the issues by converting all the responses returned from \Drupal\recurly\Controller\RecurlyPushListenerController::processPushNotification to use Symfony\Component\HttpFoundation\Response objects. Effectively this will change the response content from HTML to plain text. And bypasses core's early rendering safe guards. Since this page is really only intended for internal processing and to serve HTTP status codes to Recurly this shouldn't break anything.
I also updated one brittle test. The calculation performed in recurly_subscription_calculate_refund() depends on \Drupal::time()->getRequestTime() and as a result the output can vary slightly which causes intermittent test failures.
- Status changed to RTBC
over 1 year ago 1:42pm 16 May 2023 - πΊπΈUnited States blakehall
This looks good to me. And I'd love to get my logs cleaned up. Enthusiastic +1.
- last update
over 1 year ago 53 pass -
eojthebrave β
committed f306dfe2 on 4.x
Issue #3360519 by eojthebrave, blakehall: PHP LogicException when...
-
eojthebrave β
committed f306dfe2 on 4.x
- Status changed to Fixed
over 1 year ago 2:40pm 16 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.