- Issue created by @Matroskeen
- Assigned to Ranjit1032002
- last update
almost 2 years ago 15 pass, 2 fail - @ranjit1032002 opened merge request.
- last update
almost 2 years ago 15 pass, 2 fail - Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 7:15am 12 May 2023 - 🇮🇳India Ranjit1032002
Created MR!40 for the issue mentioned, please review.
Thank You - last update
almost 2 years ago 15 pass, 2 fail - last update
almost 2 years ago 15 pass, 2 fail - last update
almost 2 years ago Composer require failure - 🇺🇦Ukraine Matroskeen 🇺🇦 Ukraine, Lutsk
Not sure why MR fails, so I'll try upload the patch.
- 🇮🇳India ravi kant Jaipur
I have confirmed the changes with Branch checkout and applied the patch. Composer.json is removed and functionality working properly.
- Status changed to Needs work
almost 2 years ago 4:18pm 12 May 2023 - 🇺🇦Ukraine Matroskeen 🇺🇦 Ukraine, Lutsk
As you can see, the tests are failing so I wouldn't call it "working properly" :)
Perhaps we cannot remove the file... investigation is required. - last update
almost 2 years ago 16 pass, 2 fail - last update
almost 2 years ago 21 pass - 🇺🇦Ukraine Matroskeen 🇺🇦 Ukraine, Lutsk
It seems we cannot remove the composer.json file because our tests still depend on token contrib module.
We'll try to remove this dependency in another task, but in the meantime, we can remove dependencies on commerce and group. - last update
almost 2 years ago 21 pass -
Matroskeen →
committed 8bc12010 on 2.0.x
Issue #3359863: Remove commerce and group moduels from dev dependencies
-
Matroskeen →
committed 8bc12010 on 2.0.x
- Status changed to Fixed
almost 2 years ago 12:50pm 15 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.