Media module is fundamentally broken by this module

Open on Drupal.org →

Created on 10 May 2023, about 1 year ago

Problem/Motivation

Having this module enabled on a site with Media and using Ckeditor to embed the images shows that the approach trying to 404 on request is probably not sustainable.

This issue will move to only doing the 404 on response as checking the content format is much more reliable. This means we can make the route list smaller.

Steps to reproduce

Enable the media module and try to embed a video from youtube.

Proposed resolution

Do less.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

📌 Task

Status

Fixed

Version

1.0

Component

Code

Created by

🇬🇧United Kingdom alexpott 🇪🇺🌍

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @alexpott
Comment about 1 year ago →
🇬🇧United Kingdom alexpott 🇪🇺🌍
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
1 pass
@alexpott opened merge request.
Comment about 1 year ago →
🇬🇧United Kingdom alexpott 🇪🇺🌍
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
1 pass

Comment about 1 year ago →

alexpott → committed 6d01d95b on 1.0.x

Issue #3359331 by alexpott: Media module is fundamentally broken by this...

Status changed to Fixed about 1 year ago10:22am 10 May 2023
Comment about 1 year ago →
🇬🇧United Kingdom alexpott 🇪🇺🌍
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024