- Issue created by @meralvingrita24
- 🇵🇭Philippines meralvingrita24 Cabuyao City, Laguna
Uploading a new patch to handle warning messages.
- last update
over 1 year ago Build Successful - 🇵🇭Philippines meralvingrita24 Cabuyao City, Laguna
Uploading a new and improved patch to handle undefined array keys warning messages.
- last update
over 1 year ago Build Successful - last update
over 1 year ago Build Successful - 🇦🇺Australia chOP
+++ b/src/Form/MigrateRedirectForm.php @@ -171,6 +171,19 @@ my-source-path,https://example.com,und,302', + $csvHtml = t('Header line shoud follow the following labels: source,destination,language,status_code');
t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
- Status changed to Needs review
over 1 year ago 7:05am 31 May 2023 - 🇦🇺Australia chOP
Marking as needs review.
I have the following questions...
-
+++ b/src/Form/MigrateRedirectForm.php @@ -171,6 +171,19 @@ my-source-path,https://example.com,und,302', + $file->delete();
Do we need to delete the file during validation when it doesn't contain the correct CSV header row?
-
+++ b/src/Form/MigrateRedirectForm.php @@ -171,6 +171,19 @@ my-source-path,https://example.com,und,302', + break;
Should we return rather than break here?
I note that the class is already using
t()
calls and doesn't use\Drupal\Core\StringTranslation\StringTranslationTrait
and$this->t()
instead. This is probably something to address in a separate issue I suppose. -
-
plopesc →
committed efb99dbc on 2.0.x authored by
meralvingrita24 →
Issue #3359286 by meralvingrita24, chOP: Warning messages appear when...
-
plopesc →
committed efb99dbc on 2.0.x authored by
meralvingrita24 →
- Status changed to Fixed
over 1 year ago 2:43pm 9 June 2023 - 🇪🇸Spain plopesc Valladolid
Thank you for the patch @meralvingrita24.
Patch committed including some of the suggestions added by @chOP.
Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.