- Issue created by @bradjones1
- last update
over 1 year ago run-tests.sh fatal error - @bradjones1 opened merge request.
- Status changed to Needs review
over 1 year ago 9:49pm 9 May 2023 - 🇺🇸United States bradjones1 Digital Nomad Life
Entity validation was recently touched in 🐛 State transition validation should only happen after a transition is applied. Fixed as well, though indirectly through the state item's
::isValid()
method. I _think_ the changes there make this change possible. - 🇮🇱Israel jsacksick
I'm guessing the isNew() check is there to allow setting any state for new entities?
- last update
over 1 year ago run-tests.sh fatal error - 🇺🇸United States bradjones1 Digital Nomad Life
- 🇺🇸United States bradjones1 Digital Nomad Life
I'm guessing the isNew() check is there to allow setting any state for new entities?
That dates back to the initial implementation of this validator and I think it probably just didn't work at the time on new entities? Your latest changes to the validator seem to make this possible. Let's check the test results. I'll run it on 10.x instead since 9.5.x testing is temporarily broken.
- last update
over 1 year ago 26 pass - last update
over 1 year ago 26 pass - Status changed to Needs work
over 1 year ago 7:49pm 10 May 2023 - 🇺🇸United States bradjones1 Digital Nomad Life
Doesn't break existing suite on D9 or D10, I think this just needs tests.
- Status changed to Closed: duplicate
5 months ago 5:23am 25 June 2024 - 🇺🇸United States bradjones1 Digital Nomad Life
This exact change was made in 🐛 State constraint is not validated on new entities Fixed . Closing this as a duplicate.