- Issue created by @jonathan1055
- 🇬🇧United Kingdom jonathan1055
First the MR with no change to show the baseline current state of the jobs.
- Open on Drupal.org →Core: 10.1.x + Environment: PHP 8.1 & MySQL 8last update
over 1 year ago Not currently mergeable. - @jonathan1055 opened merge request.
- 🇬🇧United Kingdom jonathan1055
Baseline phpcs job https://git.drupalcode.org/project/scheduler/-/jobs/46080 shows the current failures
Also images stored on #3357870: The PHPCS job overwrites the projects own phpcs.xml.dist file → - last update
over 1 year ago 245 pass, 2 fail - 🇬🇧United Kingdom jonathan1055
The Gitlab pipeline PHPCS job for the branch is https://git.drupalcode.org/project/scheduler/-/jobs/46080
It fails on two sniffs, with errors284 | WARNING | [x] There must be no blank line following an inline | | comment (Drupal.Commenting.InlineComment.SpacingAfter)
and
873 | ERROR | [ ] The array declaration extends to column 91 (the limit is | | 80). The array content should be split up over multiple | | lines (Drupal.Arrays.Array.LongLineDeclaration)
- 🇬🇧United Kingdom jonathan1055
The PHPCS job for this MR is https://git.drupalcode.org/project/scheduler/-/jobs/46086 and it passes
- 🇬🇧United Kingdom jonathan1055
Test failures are unrelated to this issue. See 📌 SchedulerRulesEventsTest fail with "Indirect modification of overloaded property ... has no effect" Active
- last update
over 1 year ago 245 pass, 2 fail -
jonathan1055 →
committed b8ca0c1b on 2.x
Issue #3358806 by jonathan1055: Rename phpcs.xml.dist to phpcs.xml in...
-
jonathan1055 →
committed b8ca0c1b on 2.x
- Status changed to Fixed
over 1 year ago 7:25am 9 May 2023 - 🇬🇧United Kingdom jonathan1055
Renaming should not cause a big problem. Better to do this now before 2.0 release
Will also backport to 8.x-1.x to keep both branches aligned. -
jonathan1055 →
committed 389244d2 on 8.x-1.x
Issue #3358806 by jonathan1055: Rename phpcs.xml.dist to phpcs.xml in...
-
jonathan1055 →
committed 389244d2 on 8.x-1.x
Automatically closed - issue fixed for 2 weeks with no activity.