- Issue created by @Nathan Tsai
- @nathan-tsai opened merge request.
-
Nathan Tsai →
committed b8117ec3 on 2.x
Issue #3358640 by Nathan Tsai, Andrew Answer: Capitalize the Email...
-
Nathan Tsai →
committed b8117ec3 on 2.x
- Status changed to Fixed
over 1 year ago 7:43pm 6 May 2023 - 🇨🇦Canada Nathan Tsai
Andrew's original comment:
Also, I found that From and Reply-to headers do not work, because of you use lowercase in $headers array (see EmailApi.php:getHeaders() function). You need to update this code to
$headers = [ 'Content-Type' => 'text/plain; charset=UTF-8;', 'MIME-Version' => '1.0', 'Reply-to' => $replyTo, 'From' => $this->siteConfig->get('name') . ' <' . $from . '>', ];
- 🇨🇦Canada Nathan Tsai
Note: I used
Reply-To
instead ofReply-to
.Reading https://www.rfc-editor.org/rfc/rfc5322.html, I can't tell if the headers are required to be uppercase or lowercase.
It mentioned that "A" could mean upper or lowercase A and "Reply-To" is always mentioned in quotes.
Don't know, but uppercased the headers just in case.
-
Nathan Tsai →
committed b8117ec3 on fix-info-and-composer
Issue #3358640 by Nathan Tsai, Andrew Answer: Capitalize the Email...
-
Nathan Tsai →
committed b8117ec3 on fix-info-and-composer
-
Nathan Tsai →
committed b8117ec3 on master
Issue #3358640 by Nathan Tsai, Andrew Answer: Capitalize the Email...
-
Nathan Tsai →
committed b8117ec3 on master
Automatically closed - issue fixed for 2 weeks with no activity.