- Issue created by @renatog
- πΊπΈUnited States josephcheek Provo, UT
At risk of adding a comment just to say
+1
, I would love to see this. +1. - π³πΏNew Zealand ericgsmith
Bumping to major since 1.4 does not work on Drupal 10.1.
It seems multiple duplicates of this bug will keep getting raised and it has been fixed on the dev branch for months. Can we please get a release?
- πΊπΈUnited States Greg Boggs Portland Oregon
Before we tag the release, we need someone to actually test the dev branch, try at least most of the checkboxes and report back. It's quite common for base features to get broken in dev branch because each patch gets tested individually, but no one tests the entire module set once it's been merged in a complete release.
- π³πΏNew Zealand ericgsmith
Hi Greg,
Thanks for your quick response.
I understand the need for testing - but as it stands the bugfix for π Wrong RouteObjectInterface for Drupal 10 Fixed is the only item committed in the 8.x-1.x branch, which has been RTBC'd / comitted AND reported multiple times with the same fix. It is also a well documented change in line with the deprecation change record.
I take the request for a release in that issue, the duplicate patch in π Error: Class "Symfony\Cmf\Component\Routing\RouteObjectInterface" not found Closed: duplicate and the duplicate request to tag a release π Tag and release 1.5 as current stable version is broken for D10 Active as evidence this fix has been widely tested and needed.
I'll also open up a new issue to add some test coverage - I hope this doesn't block a 8.x-1.5 release but would give you more confidence in the fixes provided by the community.
π The core_version_requirement is incorrect Needs review could also be added as part of the release to fix the version requirement - but given that the current published release is unusable for Drupal 10 I would again suggest just getting the already committed fix tagged as 8.x-1.5 and a release out the door. It will surely be less admin than closing all these duplicates that will continue to come up.
- π¬π§United Kingdom Finn Lewis
Yes please, just testing an upgrade on a site that uses current_page_crumb and it breaks badly.
I'll run with the dev release for now, but a 1.5 release would be very much appreciated.
Thanks for all your work on this!
- Status changed to Fixed
over 1 year ago 3:10pm 3 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.