Interface should be used in constructor instead of class itself

Created on 5 May 2023, over 1 year ago

Problem/Motivation

After installing webprofiler → module token_default is breaking our page.

TypeError: Drupal\token_default\TokenDefaultManager::__construct(): Argument #1 ($entityTypeManager) must be of type Drupal\Core\Entity\EntityTypeManager, Drupal\webprofiler\Entity\EntityManagerWrapper given, called in /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 262 in Drupal\token_default\TokenDefaultManager->__construct() (Zeile 26 in /app/web/modules/contrib/token_default/src/TokenDefaultManager.php)

Webprofiler extends entityTypeManager and when TokenDefaultManager gets it in the constructor it is not the class it expects anymore. Interface should be used instead of exact class.

🐛 Bug report

Status

Needs review

Version

1.0

Component

Code

Created by

🇸🇮Slovenia useernamee Ljubljana

Live updates comments and jobs are added and updated live.

Dependency Injection (DI)

Comments & Activities

Issue created by @useernamee
@useernamee opened merge request.
Comment over 1 year ago →
🇸🇮Slovenia useernamee Ljubljana
Status changed to Needs review over 1 year ago9:39am 5 May 2023
Comment over 1 year ago →
🇸🇮Slovenia useernamee Ljubljana
I've provided PR.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024