Contrib.social

groupmedia_update_8001 logic for determining tracking_enabled is incorrect

Open on Drupal.org →
Created on 4 May 2023, about 1 year ago
Updated 17 May 2023, about 1 year ago

Problem/Motivation

There is a bug in groupmedia_update_8001 which incorrectly determines which bundles to apply tracking_enabled to.

The previous configuration value groupmedia.settings.bundles was a list of bundle to exclude from tracking (https://git.drupalcode.org/project/groupmedia/-/commit/dd92ffbadad1d73a1...)

The update hook incorrectly interprets this as a list of bundles to enable https://git.drupalcode.org/project/groupmedia/-/commit/dd92ffbadad1d73a1...

Steps to reproduce

  • Install groupmedia 4.0.0-alpha4
  • Add a group & enable media relation for 2 media bundles
  • Enable tracking
  • Exclude one bundle from the excluded bundles list
  • Update to 4.0.0-alpha6 and run updatedb

After the update hook, the excluded bundle has tracking_enabled, but the bundle previously being tracked does not have the value.

Proposed resolution

Get the bundles where tracking is enabled by comparing the list of media bundles and excluding any specified in groupmedia.settings.bundles

Remaining tasks

Review

User interface changes

N/A

API changes

N/A

Data model changes

N/A

🐛 Bug report
Status

Fixed

Version

4.0

Component

Code

Created by

🇳🇿New Zealand ericgsmith

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024