- Issue created by @aalin
- Status changed to Needs review
over 1 year ago 6:17am 5 May 2023 - last update
over 1 year ago Patch Failed to Apply - First commit to issue fork.
- Merge request !40Issue #3358284: js error: Cannot read properties of null (reading time) → (Merged) created by DeaOm
- last update
about 1 year ago 15 pass, 7 fail - 🇸🇮Slovenia DeaOm
The patch was not applying, but instead of re-rolling added the code to issue fork for easier maintaining. The code works, so in my POV can be merged, but will leave it to needs review. Tests are expected to fail for migrations 🌱 [META] Serialization issues in Migration tests Active .
- last update
about 1 year ago 15 pass, 7 fail - Status changed to Postponed
about 1 year ago 10:37am 22 September 2023 The fix works but will need work when 🐛 Autologout triggered in background tab, no indication in other open tabs Fixed gets merged. So I'll postpone it for now.
- last update
about 1 year ago 18 pass, 4 fail - Status changed to Needs review
about 1 year ago 12:11pm 22 September 2023 Rebased the issue everything was rebased without an issue. Setting it to needs review.
- 🇸🇮Slovenia DeaOm
Added a simple test that simulates having more then two responses from autologout ajax, by adding it in first place in array, so hard coding keys is not an option. The code in js file works as expected by checking the correct key and based on that sets the response. Leaving it as needs review so somebody can check the test added.
The testing is done via GitLab CI. To not cause confusion, hiding the patch file (which is applied in the issue fork). - Status changed to RTBC
about 1 year ago 11:51am 26 September 2023 Tests are passing here and locally, also testing by hand also worked fine. Setting this as RTBC.
- First commit to issue fork.
-
boshtian →
committed be6dd3ee on 8.x-1.x authored by
DeaOm →
Issue #3358284 by DeaOm, aalin, admirlju: js error: Cannot read...
-
boshtian →
committed be6dd3ee on 8.x-1.x authored by
DeaOm →
- Status changed to Fixed
11 months ago 11:50am 29 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.