Error after apply patch in 2313309 core issue

Created on 4 May 2023, over 1 year ago

Problem/Motivation

After applying patch in https://www.drupal.org/node/2313309 and starts appearing in the backend (at the bottom of the page)

The website encountered an unexpected error. Please try again later.
ArgumentCountError: Too few arguments to function Drupal\login_destination\LoginDestinationToolbarLinkBuilder::__construct(), 3 passed in /app/docroot/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 and exactly 4 expected in Drupal\login_destination\LoginDestinationToolbarLinkBuilder->__construct() (line 41 of modules/contrib/login_destination/src/LoginDestinationToolbarLinkBuilder.php).
Drupal\login_destination\LoginDestinationToolbarLinkBuilder->__construct(Object, Object, Object) (Line: 259)
Drupal\Component\DependencyInjection\Container->createService(Array, 'login_destination.toolbar_link_builder') (Line: 177)
Drupal\Component\DependencyInjection\Container->get('login_destination.toolbar_link_builder') (Line: 20)
Drupal\Core\DependencyInjection\ClassResolver->getInstanceFromDefinition('user.toolbar_link_builder') (Line: 117)
Drupal\Core\Controller\ControllerResolver->createController('user.toolbar_link_builder:renderDisplayName') (Line: 69)
Drupal\Core\Controller\ControllerResolver->getControllerFromDefinition('user.toolbar_link_builder:renderDisplayName') (Line: 776)
Drupal\Core\Render\Renderer->doCallback('#lazy_builder', 'user.toolbar_link_builder:renderDisplayName', Array) (Line: 353)
Drupal\Core\Render\Renderer->doRender(Array, 1) (Line: 204)
Drupal\Core\Render\Renderer->render(Array, 1) (Line: 160)
Drupal\Core\Render\Renderer->Drupal\Core\Render\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 161)
Drupal\Core\Render\Renderer->renderPlain(Array) (Line: 175)
Drupal\Core\Render\Renderer->renderPlaceholder('callback=user.toolbar_link_builder%3ArenderDisplayName&&token=-MH2NzEnTzbzMk0ZGfGgoiw7G3j_-Q1ILWBRVhIOKLI', Array) (Line: 693)
Drupal\big_pipe\Render\BigPipe->renderPlaceholder('callback=user.toolbar_link_builder%3ArenderDisplayName&&token=-MH2NzEnTzbzMk0ZGfGgoiw7G3j_-Q1ILWBRVhIOKLI', Array) (Line: 547)
Drupal\big_pipe\Render\BigPipe->sendPlaceholders(Array, Array, Object) (Line: 305)
Drupal\big_pipe\Render\BigPipe->sendContent(Object) (Line: 112)
Drupal\big_pipe\Render\BigPipeResponse->sendContent() (Line: 381)
Symfony\Component\HttpFoundation\Response->send() (Line: 20)

Steps to reproduce

Open /admin/config
scroll to the bottom of the page

Proposed resolution

To have a patch and wait for the core patch to be merged and merge this patch
To update the __construct to follow the parent class (ToolbarLinkBuilder)

Remaining tasks

Got the core issue fixed
Review

User interface changes

N/A

API changes

N/A

Data model changes

N/A

🌱 Plan
Status

Active

Version

2.0

Component

Code

Created by

🇯🇴Jordan abu-zakham

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024