- Issue created by @ericgsmith
- Status changed to Needs review
about 2 years ago 3:59am 4 May 2023 - last update
about 2 years ago 425 pass, 2 fail - last update
about 2 years ago 414 pass, 3 fail - last update
about 2 years ago 425 pass, 2 fail - 🇳🇿New Zealand ericgsmith
2 test failures are coming from 2.0.x branch - fixing coding standards issue
- last update
about 2 years ago 423 pass, 1 fail - Status changed to Needs work
about 2 years ago 2:55am 10 May 2023 - 🇳🇿New Zealand RoSk0 Wellington
At this stage it's probably better to target 3.x branch.
+++ b/src/Plugin/facets/query_type/SearchApiString.php @@ -47,7 +47,10 @@ class SearchApiString extends QueryTypePluginBase { + if ($value === '!()') {
This needs some explanation.
- Status changed to Needs review
about 2 years ago 8:35pm 10 May 2023 - Open on Drupal.org →Core: 10.1.x + Environment: PHP 8.1 & MySQL 8last update
about 2 years ago Waiting for branch to pass - 🇳🇿New Zealand ericgsmith
Added comments - in doing so I moved the condition inside the original first if statement.
I originally had it outside to avoid too many nested levels in the method - but reading the code with the comments back made me think its more logically placed inside the existing condition to keep the logic around missing item values in one place / more readable.
- Merge request !302Issue #3358083: Do not add a condition when missing filter has no values → (Open) created by ericgsmith
- 🇳🇿New Zealand ericgsmith
Moved patch to MR
Ci shows test passing + test only job failing to demonstrate the error.
Lint jobs - lots of errors / warnings on 3.0.x branch for most jobs - does not appear from a quick look to be introducing anything new here.