Latest 7.x-3.x release generates a strpos error in the new _pathologic_is_file_directory function. The value of of $dir is empty if public:// has been replaced with AWS S3 using the s3fs module:
Warning: strpos(): Empty needle in _pathologic_is_file_directory() (line 549 of /sites/all/modules/contrib/pathologic/pathologic.module).
Install pathologic and the s3fs module. Configure s3fs to be used as a replacement for public:// rather than its own stream at s3://. Loading any page will cause the warning error to be displayed.
See the attached patch. File directory check can be bypassed if $dir is empty, and s3fs module exists and is used as a public:// replacement.
Please review the attached patch and provide any feedback, thank you.
Needs review
3.0
Code
Gave this some additional thought, and the better way to handle this is just check getDirectoryPath, since s3fs will return an empty value if queried.
This allows for any other check in the function to still occur, rather than immediately returning a FALSE. See attached, thanks.