Only report remote id once per job

Created on 2 May 2023, over 1 year ago
Updated 14 September 2023, over 1 year ago

Problem/Motivation

The remote ID seems to be a per-job identifier and not per job item.

Currently, if you add many items, you have repeated messages on the job.

It looks like this:

  • Job item successfully submited. Remote ID is 490907.
  • Job item successfully submited. Remote ID is 490907.
  • Job item successfully submited. Remote ID is 490907.

And so on...

Steps to reproduce

Submit a job with multiple items.

Proposed resolution

Just report one message on the job.
Or report a real per-item id.

Remaining tasks

User interface changes

One message in UI.

🐛 Bug report
Status

Needs work

Version

1.0

Component

User interface

Created by

🇨🇭Switzerland miro_dietiker Switzerland

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @miro_dietiker
  • First commit to issue fork.
  • @ranjit1032002 opened merge request.
  • Status changed to Needs review over 1 year ago
  • 🇮🇳India Ranjit1032002

    Created MR!2 for the issue mentioned, please review.
    Thank you.

  • Status changed to Needs work over 1 year ago
  • 🇨🇭Switzerland miro_dietiker Switzerland

    Thank you for giving this a try, i checked the original code:

    The addRemoteMapping can not change, since we then would break identifying the item when translations return.

    The addMessage should move to the job outside of the loop.

    Supertext identifies item ids by just receiving GroupId (translation job item ids) and we don't need (and we don't get) a per-item remote id.

  • Status changed to Needs review over 1 year ago
  • 🇮🇳India Ranjit1032002

    @miro_dietiker I had made changes to the MR!2, please review.
    Thank You.

  • Status changed to Needs work over 1 year ago
  • 🇨🇭Switzerland berdir Switzerland

    no need to add to the job item. no need to collect and group the ids, because it's always the same.

Production build 0.71.5 2024