- Issue created by @jonathan1055
- 🇬🇧United Kingdom jonathan1055
First, run with latest coder dev, to demonstrate the problem.
- last update
almost 2 years ago 261 pass - @jonathan1055 opened merge request.
- last update
almost 2 years ago Build Successful - last update
almost 2 years ago Build Successful - 🇬🇧United Kingdom jonathan1055
The development version of Coder is being fetched successfully. But the list of sniffs read from Coders ruleset.xml is not being refreshed. The output in phpcs_sniffs.txt just has the original two
SlevomatCodingStandard (2 sniffs) --------------------------------- SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator SlevomatCodingStandard.PHP.ShortList
So how do we refresh this from the newly updated Coder source?
- last update
almost 2 years ago Build Successful - last update
almost 2 years ago Build Successful - last update
almost 2 years ago Build Successful - last update
almost 2 years ago Build Successful - last update
almost 2 years ago Build Successful - last update
almost 2 years ago Build Successful - last update
almost 2 years ago Build Successful - last update
almost 2 years ago Build Successful - 🇬🇧United Kingdom jonathan1055
I failed to get DrupalCI phpcs step to use the new sniff, even though the latest Coder dev version is loaded.
But now that Scheduler runs GitLab-CI pipelines we see in this pipeline the failing PHPCS job, due to the three incorrectly ordered sniffs.
PHP CODE SNIFFER VIOLATION SOURCE SUMMARY ------------------------------------------------------------------------------------ SOURCE COUNT ------------------------------------------------------------------------------------ [x] SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrdered 3 ------------------------------------------------------------------------------------ A TOTAL OF 3 SNIFF VIOLATIONS WERE FOUND IN 1 SOURCE ------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SOURCES AUTOMATICALLY (3 VIOLATIONS IN TOTAL) ------------------------------------------------------------------------------------
- last update
almost 2 years ago 229 pass -
jonathan1055 →
committed ccbfba0e on 2.x
Issue #3357619 by jonathan1055: New coding standard - Alphabetically...
-
jonathan1055 →
committed ccbfba0e on 2.x
-
jonathan1055 →
committed d854e920 on 8.x-1.x
Issue #3357619 by jonathan1055: New coding standard - Alphabetically...
-
jonathan1055 →
committed d854e920 on 8.x-1.x
- Status changed to Fixed
almost 2 years ago 12:03pm 24 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.