Impossible to set password when creating a account

Bug fix and test only patch for proof.

The last submitted patch, 2: openid_connect-3357538-2-test-only.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Initial thought - would the same bug would be present on the user form when the current user is an admin and they are editing another user without a linked account? It feels unrelated to the specific form id.

It seems like an incorrect assumption in the module that the form is for the current user.

The comment in the existing code "// Whether the current user is allowed to change its password." is not checking that at all - its checking the currently logged in user.

Could you do something like this?

  // Whether the user's password is changeable its password.
  $account = $form_state->getFormObject()->getEntity();
  if (\Drupal::service('openid_connect.openid_connect')->hasSetPasswordAccess($account)) {
    return;
  }

True, this needs a bit more work. On it.

Improved patch version.

Thanks for the pointer Eric!

The last submitted patch, 7: openid_connect-3357538-7-test-only.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Perfect. Back to NR.

Change and test looks good to me and resolves the issue. Changing to RTBC

Thanks all for the work on this! I reworked the patch from #7 into a new merge request. I took the moment to expand test coverage too. If someone has a moment to review, I'd appreciate it.

Thanks again for the fix. This has been merged to 3.x.