Implode does not work for arrays

Oh, good catch. I was just looking through the tamper plugins that come with an optional annotation handle_multiples = TRUE which is documented like this:

Typically plugins that have handle_multiples as TRUE will expect an array as input and iterate over it themselves, changing the whole array.

We could read that property from the plugin and if this is set to TRUE, we can use the alternate token extraction method. That way, we keep the intact functionality for all other plugins and fix the array issue not only for the implode but also for other plugins that expect data to be an array.

Sounds good 👍

Took a look and left one note.

Addressed all threads, NR again.

@mxh would you mind another quick review?

Took a quick look at the code, looks fine to me. Unfortunately currently got no time for a thorough test.

Self-defined lists that are wrapped by DataTransferObject are most probably fine. Guess another plausible case would be the attempt to implode field values, using something like [node:field_my_list] as token. Would be interesting to see how the implode plugin then behaves. Maybe it needs an array of scalars?

I've added support for EntityReferenceFieldItemListInterface and FieldItemListInterface which is working nicely. Maybe another quick look?

Attached is a model for testing.

Took another look and left one note, otherwise I think it's fine.

Thanks @mxh for working on this with me. Now resolved and marked as fixed.

Automatically closed - issue fixed for 2 weeks with no activity.