Should display values use $this->t() in defaultSettings()?

Created on 27 April 2023, about 1 year ago
Updated 3 July 2023, 12 months ago

Problem/Motivation

Currently the more link and more aria label settings do not use the $this->t() function. This will result in the defaults not being translated.

Steps to reproduce

I guess translate the UI to another language, and verify that More link text and More aria-label default to English values.

Proposed resolution

Verify that translating is the correct thing to do.

Update defaultSettings() to add $this->t()

Remaining tasks

Do the things.

User interface changes

Defaults would be translated.

API changes

None

Data model changes

None

🐛 Bug report
Status

Closed: duplicate

Version

2.0

Component

Code

Created by

🇮🇪Ireland lostcarpark

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.69.0 2024