Make it compatible with Webform v6

Created on 26 April 2023, about 1 year ago
Updated 3 May 2023, about 1 year ago

Problem/Motivation

Currently when we enable 8.x-1.0-beta1 module, we receive following error:
"You have requested a non-existent service "entity.manager".
Since this service is removed, module is not able to get the correct service.

Steps to reproduce

Install module along with latest webform V6 branch (I'm on 6.1.4)
Once we enable the module via Drush, we get the above error.

Proposed resolution

Delegating base createInstance() method to base class and adding necessary dependency only.
That way we just need to worry about new dependency only.

Patch is attached with the issue.

Remaining tasks

Review required.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

🐛 Bug report
Status

Needs review

Version

1.0

Component

Code

Created by

🇮🇳India mohit_aghera Rajkot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @mohit_aghera
  • @mohit_aghera opened merge request.
  • Status changed to Needs review about 1 year ago
  • 🇫🇷France paul_leclerc Lausanne Switzerland

    https://www.drupal.org/project/webform_encrypt/issues/3142997 📌 Webform Encrypt D9 readiness Fixed
    This patch fixes the issue.

    But when saving the form I still having another new fatal error.

  • 🇮🇳India mohit_aghera Rajkot

    Thanks for testing @paul_leclerc
    Can you tell me what's the error. May be I can look into it.

  • 🇫🇷France paul_leclerc Lausanne Switzerland

    The new error append when sending the webform.

    Drupal\Core\Entity\EntityStorageException: in Drupal\Core\Entity\Sql\SqlContentEntityStorage->save() (line 815 of core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php).
    Drupal\encrypt\EncryptService->encrypt() (Line: 122)
    Drupal\webform_encrypt\WebformEncryptSubmissionStorage->encrypt() (Line: 74)

    I could trace the error until Key.php > loadFromAsciiSafeString > return new Key($key_bytes); (l51)

  • 🇮🇳India mohit_aghera Rajkot

    Interesting, this patch works fine for me. Are you using the patch uploaded here https://www.drupal.org/project/webform_encrypt/issues/3142997 📌 Webform Encrypt D9 readiness Fixed on the other issues?

Production build 0.69.0 2024