Contrib.social

Map Type Control not working due to strict type check

Open on Drupal.org →
Created on 25 April 2023, almost 2 years ago
Updated 6 June 2023, over 1 year ago

Problem/Motivation

Selecting Enabled Map Type Control and then checking on the The enabled Map Types is not working as desired. All options are always being shown.

Steps to reproduce

Set up a display, enable Map Type Control and select only one of the Map Types to show. Observe they all show regardless.

Proposed resolution

The array filter is doing a $value !== 0 check but the 0 is actually a string from the config file, change this to a simple != check

🐛 Bug report
Status

Closed: cannot reproduce

Version

3.0

Component

Code

Created by

🇺🇸United States nsciacca

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @nsciacca
  • @nsciacca opened merge request.
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇮🇹Italy itamair

    Thanks @nsciacca ... going to Review and QA this asap.

  • Status changed to Closed: cannot reproduce over 1 year ago
  • Comment over 1 year ago →
    🇮🇹Italy itamair

    Ehi @nsciacca ... I tried to reproduce what you report here, and I cannot.
    When I Enable Map Type Control only the Enabled Map Types are shown as possible options on the Map ...
    I am closing this, as I cannot reproduce (with Geofield Map 3.0.8).

    Reopen this with much more evidence of your issue (may be some screenshot to prove what you experience).

  • Comment over 1 year ago →
    System Message
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024