Fix outdated names/comments for confirmations

Created on 25 April 2023, over 1 year ago
Updated 1 August 2023, over 1 year ago

Problem/Motivation

Several fixes have changed how confirmation works, and the names/comments in some places are confusing. In many places, reference to "combined" should now be "subscribe".

Proposed resolution

Make changes wherever it's not to disruptive.

  • Change: routes, URLs, function names, comments, form text, data model (with update hook), token names (keep old with deprecation)
  • Don't change: mail keys

This change is not BC so needs to wait until a new version 4.x.

Remaining tasks

User interface changes

Changes to routes and URLs.

API changes

MailBuilderInterface::buildCombinedMail() changed to buildSubscribeMail()
MailerInterface::sendCombinedConfirmation() changed to sendSubscribeConfirmation()

Data model changes

📌 Task
Status

Fixed

Version

4.0

Component

Code

Created by

🇬🇧United Kingdom adamps

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024