- Issue created by @nitrocad
- Status changed to Needs review
over 1 year ago 1:46pm 19 April 2023 Attached a patch set that fixes the issues for me, although I just did some little testing if the Insert button shows up again and inserting an image basically works.
The core requirement would need to be bumped directly to version 10 without backward compatibility, because Twig has been upgraded to version 3 along with Drupal 10, which requires changes to be made in the template files. Drupal 9.2 had deprecated
hook_field_widget_form_alter
, which is superseded byhook_field_widget_single_element_form_alter
.Of course, the CKEditor legacy module has to be used as of now. As for upgrading the CKEditor dependency, there is a separate issue: https://www.drupal.org/project/insert/issues/3314446 π CKEditor 5 compatibility Active
Setting this ticket to major priority, which I'll also assign to the CKEditor issue to draw attention.
Thanks for the patch.
I tested it too on D10.0.7 with CKE4 and Colorbox, and it seems working fine!
Once is missing, the submodules version requirement need to be updated too.
Thanks for checking. Forgot about the submodules, there is also another occurrence of
hook_field_widget_form_alter
. Updated patch attached.- Status changed to RTBC
over 1 year ago 1:43pm 28 June 2023 - πΊπΈUnited States mlncn Minneapolis, MN, USA
This should probably get another major version branch release given the need to drop D9 support.
(And then another major version for CKeditor5?)
But it's needed now, obviously, for sites to move to Drupal 10.
Patch does that, and looks good!
- First commit to issue fork.
- @dioni opened merge request.
- @dioni opened merge request.
- Status changed to Fixed
over 1 year ago 11:49am 1 August 2023 Patch is merged and 3.0.0 beta release β is created.
If things are fine, will make a final 3.0.0 release within the next few weeks.
Thanks to everyone involved here.Automatically closed - issue fixed for 2 weeks with no activity.