Deprecation warning 'Not marking service definitions as public is deprecated'

Created on 18 April 2023, over 1 year ago
Updated 22 April 2023, over 1 year ago

Problem/Motivation

Not marking service definitions as public is deprecated in drupal:9.2.0 and is required in drupal:10.0.0. Call $definition->setPublic(TRUE) before calling ::setDefinition(). See https://www.drupal.org/node/3194517

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Needs review

Version

1.0

Component

Code

Created by

🇬🇧United Kingdom joachim

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @joachim
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
    last update over 1 year ago
    Waiting for branch to pass
  • @joachim opened merge request.
  • Status changed to Needs review over 1 year ago
  • 🇨🇦Canada m4olivei Grimsby, ON

    @joachim there is metion in the Project Update Bot issue for Drupal 10 that this module may not be necessary in Drupal 10 ( https://www.drupal.org/project/better_normalizers/issues/3286221#comment... 📌 Automated Drupal 10 compatibility fixes RTBC ), in which case, the patch here wouldn't have much value. I'm working on a site that has this dependency, not knowing much about it, trying to work out next steps. Curious if you had thoughts about that as it feels like you're further along than I am. Thanks!

  • 🇬🇧United Kingdom joachim

    No idea, sorry! This module was in a project I was updating to D10, so I fixed the deprecations. I've not looked into it any further than that.

Production build 0.71.5 2024