- Issue created by @dww
- Status changed to Needs review
about 2 years ago 11:53pm 17 April 2023 - πΊπΈUnited States dww
Here's the patch for both 8.x-1.x branch and the 8.x-1.4 official release (which for sites that want to patch that release until 8.x-1.5 is out).
Note that the existing code is wrongly trying to use
t()
to get the localized term name. You can only uset()
for string literals. This is a "translatable" string that only contains a placeholder, so there's nothing to translate. The localized term name is handled for us when we load the vocabulary tree. See what core is doing incore/modules/taxonomy/src/Form/TermForm.php
.There are no automated tests for this module, so I'm not including any test coverage. But it's a trivial patch. π
Please let me know if you have any questions or concerns.
Thanks!
-Derek - πΊπΈUnited States dww
Fixing embedded screenshots, sorry for the noise.
-
fjgarlin β
committed e9d2d9b0 on 8.x-1.x authored by
dww β
Issue #3354750 by dww: Term selection UI does not handle taxonomy depth
-
fjgarlin β
committed e9d2d9b0 on 8.x-1.x authored by
dww β
- Status changed to Fixed
about 2 years ago 9:04am 18 April 2023 - πͺπΈSpain fjgarlin
Thanks so much for creating the issue and the patch. I reviewed it and also tested via drupalpod and I'm happy with the changes.
I've committed already and I am creating a new tag 8.x-1.5. Automatically closed - issue fixed for 2 weeks with no activity.