- Issue created by @urvashi_vora
- 🇺🇸United States danflanagan8 St. Louis, US
This is completely moot now since I've gone a very different direction with the code.
FILE: ..._transparency/src/PathProcessor/HospitalPriceTransparencyPathProcessor.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------
22 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
35 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
42 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
--------------------------------------------------------------------------------
FILE: ..._price_transparency/src/Controller/HospitalPriceTransparencyController.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
22 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
--------------------------------------------------------------------------------
Time: 762ms; Memory: 10MB
Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig hospital_price_transparency/
Add dependency injection
Patch Review and fix remaining issues.
FILE: ..._transparency/src/PathProcessor/HospitalPriceTransparencyPathProcessor.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
61 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
--------------------------------------------------------------------------------
FILE: ..._price_transparency/src/Controller/HospitalPriceTransparencyController.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
22 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
--------------------------------------------------------------------------------
Time: 590ms; Memory: 10MB
Closed: outdated
1.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
This is completely moot now since I've gone a very different direction with the code.