- Issue created by @Ambient.Impact
- π¨π¦Canada Ambient.Impact Toronto
Alright, pushed a commit to the issue fork. Going to call it a day here because brain tired but it probably needs both a test to verify that the module weight is higher than Config Enforce's and also probably invalidating the relevant cache tag for hooks/module weights because this currently requires a manual cache clear after installing to get it to actually use the new weight.
- Status changed to Needs work
about 1 year ago 3:10pm 18 April 2023 - π¨π¦Canada Ambient.Impact Toronto
Updating title to be more accurate of what this needs to do.
- last update
about 1 year ago 1 pass - @ambientimpact opened merge request.
- last update
about 1 year ago 1 pass - Assigned to spiderman
- Status changed to Needs review
about 1 year ago 7:49pm 18 April 2023 - π¨π¦Canada Ambient.Impact Toronto
This works for me locally and tests seem to be passing, but am kind of tired out after dentist so not exactly the energy to write a test for this. Maybe we can merge this and then open a follow up to add a test?
Wondering how we can actually test this because by design, the module handler service no longer provides a method to get existing implementations for a given hook in Drupal 10 β so that a fully OOP hook system has one less barrier to being implemented, so instead we could probably create a test module that implements that depends on both Config Enforce and Config Enforce Devel and
\hook_module_implements_alter()
, which would hopefully run after the Config Enforce Devel implementation (what do you want to bet I'll eat those words?), where we could save it to state storage; we could then invoke that hook from our test, and then check state storage for the result, asserting against the expected order. - last update
about 1 year ago 2 pass - Issue was unassigned.
- Status changed to Fixed
about 1 year ago 5:18pm 19 April 2023 - π¨π¦Canada Ambient.Impact Toronto
I sat down today and figured out how to write a test for this so you're welcome merged and fixed byyyyye.
Automatically closed - issue fixed for 2 weeks with no activity.