- Issue created by @vimal_nadar
- 🇮🇳India vimal_nadar
I have added the 3 missing library types key to the make file.
- Status changed to Needs review
over 1 year ago 9:46am 14 April 2023 - Status changed to RTBC
over 1 year ago 9:54am 14 April 2023 - 🇬🇧United Kingdom lesleyfernandes
I reviewed that fix, and it is working fine. I am not seeing warnings here.
- Status changed to Postponed: needs info
over 1 year ago 4:08pm 14 April 2023 - 🇮🇩Indonesia gausarts
Thank you.
It was fine for years, and now broken?
May I know your setup for a repro?Upstream breaking changes are never a bug, otherwise no projects would never reach any stability of their own. We should adapt to or update it as a Task instead.
Deep ponder mode. This file has caused a handful of issues this far. While this is useful to some devs, but it apparently costs more maintainenance. I am thinking to remove it as I can no longer support things that cost me more maintainenance that I can afford at least just as recently.
- 🇮🇳India vimal_nadar
During the build process of a Drupal 7.95 version site with PHP 8.0, a warning message is displayed when installing this module using a make file, indicating a potential issue or warning related to PHP 8.0 compatibility.
- Issue was unassigned.
- Status changed to Postponed
over 1 year ago 10:09am 15 May 2023 - 🇮🇩Indonesia gausarts
Last time I tried PHP8 for D7, it was like opening a can of worms.
Too many modules incompatible to deal with.This should be in, but let's postpone this till I can get back to it.
Thanks.
- 🇬🇧United Kingdom lesleyfernandes
Hi gausarts,
This patch is promoting a simple change, and PHP 7.x has already reached EOL:
https://www.php.net/supported-versions.phpReviewing the code using PHPCS to check if changes are required to make the code fully compatible with PHP 8.1+ would be nice.
-
gausarts →
committed 53f1866e on 7.x-2.x authored by
vimal_nadar →
Issue #3354209 by vimal_nadar, lesleyfernandes: Undefined property:...
-
gausarts →
committed 53f1866e on 7.x-2.x authored by
vimal_nadar →
- Status changed to Fixed
over 1 year ago 9:04pm 5 July 2023 - 🇮🇩Indonesia gausarts
Got it! I said at #10: "This should be in, but let's postpone this till I can get back to it."
No biggies. Committed. Thank you for contribution and patience.
Automatically closed - issue fixed for 2 weeks with no activity.