Destination query parameter should not have precedence over path in redirect

It looks like this is not realy a lupus_ce_renderer but a designed behavior in \Drupal\Core\EventSubscriber\RedirectResponseSubscriber::checkRedirectUrl the destination parameter has precedence and is set as targetUrl on RedirectResponse.

This is a Drupal feature - In general it makes sense, but not when we are doing admin fallback redirects (See https://www.drupal.org/project/lupus_ce_renderer/issues/3272161 ✨ Implement admin fallback redirect Fixed )

Could we undo/prevent this Drupal logic somehow - only for Drupal admin fallback redirects, but keep the original path as is, with destination parameter?

I've simply removed destination query parameter from request. I think this won't have any undesirable consequences (in cases where destination query parameter is actually desired). If later will be the case we can make it a bit more complicated and just add a lupus_ce_renderer_redirect attribute to request and then write a service decorator for RedirectResponseSubscriber that has another condition before applying the destination query parameter override.

For now this solution works:

<base-url>/ce-api/node/add/article?destination=bar => "<base-url>/node/add/article?destination=bar"

Yep, agreed. Patch looks good. Let's get it tested!

Works on our ci environments and no regressions were recorded, Thus merging.

Automatically closed - issue fixed for 2 weeks with no activity.