In _fillCiviCRMData check if $element exists before trying access offsets

Created on 8 April 2023, about 1 year ago

Updated 18 July 2023, 12 months ago

1.0 Problem/Motivation

In _fillCiviCRMData() line 196 it attempts to get the element for a given key based on submission data, and then checks the $element as an array even if it is NULL: if (!empty($val) && $element['#type'] == 'civicrm_options') {

But I found it's possible that there is no longer such an element no longer exists but the previous submissions are still there. I'm guessing in normal conditions the UI would clean up the previous submissions but it's no guarantee.

2.0 Detailed steps to reproduce (embed screenshots)

I can't think of any easy way to reproduce.

3.0 Proposed resolution

Skip the $element if it's NULL since it's obviously not a 'civicrm_options' type.

🐛 Bug report

Status

Fixed

Version

6.2

Component

Code

Created by

🇨🇦Canada nubeli

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @nubeli
Status changed to Needs review about 1 year ago5:25pm 9 April 2023
Comment about 1 year ago →
🇨🇦Canada nubeli
PR ready for another review https://github.com/colemanw/webform_civicrm/pull/866#pullrequestreview-1...
Status changed to Fixed about 1 year ago4:27pm 14 May 2023
Comment about 1 year ago →
🇬🇧United Kingdom kenorb
PR has been merged.
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.
Status changed to Fixed 12 months ago1:43pm 18 July 2023
Comment 12 months ago →
🇨🇦Canada nubeli
This issue is marked as fixed but the PR is still open: https://github.com/colemanw/webform_civicrm/pull/866. What was fixed and where?

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024