Maximum Discount Price for Percentage Off Type In Promotion

I think this change could cause problems for existing sites. For one, the "percentage" amount in the adjustments is no longer correct in all cases. It blurs the line between a percentage-off offer and a fixed-price-off offer.

Why not just create a new custom promotion offer plugin, in a custom module?

@lisastreeter this will not affect already exist sites i guess. bcoz i added condition like if this field contain value, then only it will work. in already existing site the field value will be empty. so it will not cause any issue to those sites.

i tried ways to achieve this feature with existing offer types but no success.

why i didn't create plugin, this functionality is usefull in percentage off. and percentage off is already there.so i thought to modify it.

i will check for the promotion offer plugin.

@asishsajeev I'm not concerned with the added condition, but some sites might have custom code to do things like sort promotions by generosity and apply the best to each order item. The new PromotionEvents::FILTER_PROMOTIONS event makes it possible to do that.

If custom logic depends on the assumption that the percentage amount for a promotion is accurate, then this new option could cause problems. Somebody (a content creator) could create a new promotion with the existing offer type and think it was perfectly fine to use the new optional maximum feature, not knowing anything about the inner workings of the site's custom code.

But maybe I'm worrying unnecessarily--this will not personally affect me as it is... One improvement, though, would be to correctly set the "percentage" value for the adjustment. Though I'm not sure whether it would be correct to just eliminate "percentage" from the adjustment data completely when the threshold is reached. Or whether it should just be calculated based on the amount of the adjustment. (The OrderFixedAmountOff offer plugin does not include the percentage amount. The OrderPercentageOffer uses the percentage from configuration.)

I do think this is a great idea, btw. I just worry about unintended consequences for sites that have done custom things to make promotions work for them.

@lisastreeter ok. i understood.