D10 Compatibility: Version 2.x

Created on 1 April 2023, over 1 year ago
Updated 3 April 2023, over 1 year ago

Problem/Motivation

The module needs to be checked for deprecations and a D10 version released.

Remaining tasks

  • Open 2.x branch and switch to semantic versioning
  • Scan with Drupal Rector and review.
  • Manual scan with phpstan and fix.
  • Scan with Drupal Rector

User interface changes

None

API changes

None

Data model changes

None

πŸ“Œ Task
Status

Fixed

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States fathershawn New York

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @fathershawn
  • πŸ‡ΊπŸ‡ΈUnited States fathershawn New York

    No rector or phpstan reports.

    Test fails with:

    GET request to: http://web/checkout/1/payment
    The website encountered an unexpected error. Please try again later.
    
    Drupal\Core\Entity\Query\QueryException: Entity queries must explicitly set whether the query should be access checked or not. See Drupal\Core\Entity\Query\QueryInterface::accessCheck(). in Drupal\Core\Entity\Query\Sql\Query->prepare() (line 141 of core/lib/Drupal/Core/Entity/Query/Sql/Query.php).
    Drupal\Core\Entity\Query\Sql\Query->execute() (Line: 353)
    Drupal\commerce_purchase_order\Plugin\Commerce\PaymentGateway\PurchaseOrderGateway->authorizePayment(Object) (Line: 218)
    Drupal\commerce_purchase_order\Plugin\Commerce\PaymentGateway\PurchaseOrderGateway->createPayment(Object, 1) (Line: 179)
    Drupal\commerce_payment\Plugin\Commerce\CheckoutPane\PaymentProcess->buildPaneForm(Array, Object, Array) (Line: 546)
    Drupal\commerce_checkout\Plugin\Commerce\CheckoutFlow\CheckoutFlowWithPanesBase->buildForm(Array, Object, 'payment')
    call_user_func_array(Array, Array) (Line: 534)
    Drupal\Core\Form\FormBuilder->retrieveForm('commerce_checkout_flow_multistep_default', Object) (Line: 281)
    Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 222)
    Drupal\Core\Form\FormBuilder->getForm(Object, 'payment') (Line: 143)
    Drupal\commerce_checkout\Controller\CheckoutController->formPage(Object)
    call_user_func_array(Array, Array) (Line: 123)
    Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
    Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
    Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
    Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 163)
    Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 74)
    Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
    Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
    Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
    Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
    Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
    Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
    Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 51)
    Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 686)
    Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
    
    
  • @fathershawn opened merge request.
  • @fathershawn opened merge request.
  • @fathershawn opened merge request.
  • @fathershawn opened merge request.
  • Status changed to Fixed over 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States fathershawn New York

    2.0.0-beta1 is released. Please note success here or open an new issue against 2.0.x if a bug is found.

Production build 0.71.5 2024