Make PHP 7.4 and PHP 8.1 compatible

Open on Drupal.org →

Created on 30 March 2023, almost 2 years ago

Problem/Motivation

Why:
The module must be available for Drupal 9.5 and Drupal 10
Requirements of the cores:
* 9.5 - "php": ">=7.3.0"
* 10.0 - "php": ">=8.1.0"

So, our module must be available for both PHP versions. But version 7.3 is a bit outdated, but 7.4 prepares us as much as possible for the move to PHP 8+. Therefore the module must be compatible with "php": ">=7.4.0"
Composer requirements will be added in the 📌 composer.json Fixed

Proposed resolution

At the moment module is compatible with PHP 8.1 which was tested on the real project.
So we have to rework some parts of the code to make them PHP7.4 compatible.
For example:
- SeoUrlSubscriber.php
- SeoUrlManager.php

📌 Task

Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇦Ukraine HitchShock Ukraine

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @HitchShock
@hitchshock opened merge request.
Status changed to Fixed almost 2 years ago1:47pm 30 March 2023

Comment almost 2 years ago →

🇺🇦Ukraine HitchShock Ukraine

Tested the module with PHP 7.4 and PHP 8.1
Checked the module with phpcs

phpcs -p --ignore="*/vendor/*" --extensions=php,inc,module,install,theme --colors --runtime-set testVersion 7.4 --standard=PHPCompatibility ./
........... 11 / 11 (100%)


Time: 82ms; Memory: 10MB


phpcs -p --ignore="*/vendor/*" --extensions=php,inc,module,install,theme --colors --runtime-set testVersion 8.1 --standard=PHPCompatibility ./
........... 11 / 11 (100%)


Time: 81ms; Memory: 10MB

Comment almost 2 years ago →
System Message

HitchShock → committed 9c073ab6 on 1.0.x
Resolve #3351295 "Make php 7.4"
Issue was unassigned.
Comment almost 2 years ago →
🇺🇦Ukraine HitchShock Ukraine
Comment almost 2 years ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024