Fix coding standards and phpstan errors

phpcs ===== FILE: ...k/.dropsolid_launchpad/projects/phpunit/docroot/modules/contrib/seo_urls/src/Controller/SeoUrlCreateController.php ------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------ 32 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 107 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ------------------------------------------------------------------------------------------------------------------------ FILE: ...k/.dropsolid_launchpad/projects/phpunit/docroot/modules/contrib/seo_urls/src/PathProcessor/SeoUrlPathProcessor.php ------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------ 34 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ------------------------------------------------------------------------------------------------------------------------ Time: 148ms; Memory: 12MB phpstan ======= ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- Line Controller/SeoUrlCreateController.php ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 78 Method Drupal\seo_urls\Controller\SeoUrlCreateController::vocabularyTitle() should return string but returns array<string, array|Drupal\Core\StringTranslation\TranslatableMarkup|string|null>. ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- ------ --------------------------------------------------------------------------- Line EventSubscriber/SeoUrlSubscriber.php ------ --------------------------------------------------------------------------- 25 Promoted properties are supported only on PHP 8.0 and later. 38 Call to an undefined method Drupal\seo_urls\SeoUrlManager::setCacheKey(). 46 Call to an undefined method Drupal\seo_urls\SeoUrlManager::writeCache(). ------ --------------------------------------------------------------------------- ------ --------------------------------- Line MenuLinkDestination.php ------ --------------------------------- 35 Left side of && is always true. ------ --------------------------------- ------ ----------------------------------------------------------------------------------- Line Plugin/Validation/Constraint/UniqueLinkValueValidator.php ------ ----------------------------------------------------------------------------------- 44 Access to an undefined property Symfony\Component\Validator\Constraint::$message. ------ ----------------------------------------------------------------------------------- ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- Line SeoUrlManager.php ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 75 Property Drupal\seo_urls\SeoUrlManager::$preloadedPathLookups (array) does not accept default value of type false. 98 Promoted properties are supported only on PHP 8.0 and later. 226 Method Drupal\seo_urls\SeoUrlManager::getSeoUrlEntity() should return Drupal\taxonomy\TermInterface|null but returns Drupal\Core\Entity\ContentEntityInterface. 305 Method Drupal\seo_urls\SeoUrlManager::getCanonicalEntities() should return array<Drupal\Core\Entity\ContentEntityInterface> but returns array<string, Drupal\Core\Entity\EntityInterface>. ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- [ERROR] Found 10 errors

Comments & Activities

Issue created by @HitchShock
@hitchshock opened merge request.
Comment almost 2 years ago →
System Message

HitchShock → committed 8245441b on 1.0.x
Resolve #3351285 "Fix codding standards"
Status changed to Fixed almost 2 years ago3:55pm 30 March 2023

Comment almost 2 years ago →

🇺🇦Ukraine HitchShock Ukraine

Fixed codding standards and PHPstan errors.
Retested the modules after the fixes.
Rechecked the code via phpcs, phpmd, phpstan, yamllint. Used GrumPHP for that:

php ./etc/grumphp/vendor/bin/grumphp run --config=etc/grumphp
GrumPHP is sniffing your code!

Running tasks with priority 0!
==============================

Running task 1/4: phpcs... ✔
Running task 2/4: phpmd... ✔
Running task 3/4: phpstan... ✔
Running task 4/4: yamllint... ✔

Comment almost 2 years ago →
🇺🇦Ukraine HitchShock Ukraine
Issue was unassigned.
Comment almost 2 years ago →
🇺🇦Ukraine HitchShock Ukraine
Comment almost 2 years ago →
🇺🇦Ukraine HitchShock Ukraine
Comment almost 2 years ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix coding standards and phpstan errors

Problem/Motivation

Proposed resolution

Comments & Activities