Remove unnecessary public methods from VaultLeaseStorageInterface

Created on 29 March 2023, about 1 year ago

Problem/Motivation

After 📌 Move lease renewal to LeaseStorage plugins. Fixed the number of method that need to be public has been reduced.

Steps to reproduce

Review code.

Proposed resolution

Remove getLeaseId() and deleteLease() from VaultLeaseStorageInterface,
The getLeaseId() method can be converted to a protected method in VaultLeaseStorageBase.
deleteLease() can be made an abstract protected method in VaultLeaseStorageBase() to be implemented by plugins.

Remaining tasks

Patch

User interface changes

None

API changes

Remove getLeaseId() and deleteLease() from VaultLeaseStorageInterface

Data model changes

None

📌 Task

Status

Fixed

Version

2.0

Component

Code

Created by

🇺🇸United States cmlara

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @cmlara
@cmlara opened merge request.
Comment about 1 year ago →
System Message

cmlara → committed 419c85e8 on 2.x
Issue #3350979 by cmlara: Remove unnecessary public methods from...
Status changed to Fixed about 1 year ago4:23am 29 March 2023
Comment about 1 year ago →
🇺🇸United States cmlara
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024