- Issue created by @bkosborne
- 🇳🇱Netherlands eelkeblok Netherlands 🇳🇱
Definately sounds like a plan, would be open to MRs. I wonder if this would warrant a 2.0 version, as it is quite a fundamentally different approach.
This module updates affected entities using the Entity API, by loading the entity, performing the embed code swap, and saving it again. This ignores all the past revisions which could be a problem when someone reverts to an old revision. It also causes the entities updated date to be reset to the current time which is not great as it's not really a human that did this change and it might confuse editors on the site. This is especially true because it will seem like the last person to edit the node is also the person to made this change.
Instead of using the Entity API, what about doing a direct database query to replace the values? It's more risky but it allows avoiding the problems above, and it allows editing the revision data too.
Active
1.0
Code
Definately sounds like a plan, would be open to MRs. I wonder if this would warrant a 2.0 version, as it is quite a fundamentally different approach.