- Issue created by @netsliver
- π¬π§United Kingdom adamps
Thanks for the issue and patch.
Every EmailBuilder in this module is as a good example of the best way (in my opinionπ) to write code for this module.
I looked at the code for forward module. It's interesting, almost everything in
ForwardForm.php
could be replaced by features of this module.ForwardEmailBuilder
would callEmailInterface::setBodyEntity()
. Almost everything else can be handled with Mailer Policy: the header, footer, the alter hooks, the from and reply-to addresses, the setting for plain text mode, etc. This would be something for the module maintainers to decide, and it could come with a new major version release. Probably they would wait a bit - if this module later gets 20000 sites using it then that makes the difference.If we're not going to do that, then it's best not to have an EmailBuilder, because creating one blocks the useful features of
LegacyEmailBuilder
, especially callinghook_mail_alter()
. It looks like there is just one address field that is NULL. This can be fixed in the forward module, probably it just takes an if statement to avoid setting the header to a NULL value. - Status changed to Active
almost 2 years ago 11:57am 1 May 2023 - π¬π§United Kingdom adamps
I think this belongs in the forward module for the maintainers to decide how to go forward
- First commit to issue fork.
- Merge request !5Fixes 3350700 - Adds EmailBuilder plugin to support Symfony Mailer β (Open) created by scottsawyer
- πΊπΈUnited States scottsawyer Atlanta
Uploading patch for convenience. Minimal testing was done. Hopefully this is a good approach.